Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
test:
name: Run pytest
runs-on: ubuntu-20.04
timeout-minutes: 22
timeout-minutes: 25
strategy:
matrix:
python-version: ['3.10', '3.11', '3.12']
Expand Down
32 changes: 32 additions & 0 deletions tests/codemods/test_walrus_if.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,3 +181,35 @@ def func(y):
print("whatever", y)
"""
self.run_and_assert(tmpdir, input_code, expected_output)

@pytest.mark.xfail(reason="Need to recompute line numbers to reflect removed lines")
def test_multiple_walrus_changes(self, tmpdir):
input_code = """
val = do_something()
if val is not None:
do_something_else(val)

foo = hello()
if foo == "bar":
whatever(foo)

bar = do_something_else()
if bar is not None:
do_something(bar)
"""
expected_output = """
if (val := do_something()) is not None:
do_something_else(val)

if (foo := hello()) == "bar":
whatever(foo)

if (bar := do_something_else()) is not None:
do_something(bar)
"""
self.run_and_assert(tmpdir, input_code, expected_output, num_changes=3)

changes = self.changeset[0].changes
assert changes[0].lineNumber == 2
assert changes[1].lineNumber == 5
assert changes[2].lineNumber == 8