[imharjot]

Problem

A Git config ending in bare = "true\ is rejected by Git, but the continuation parser in #30174 reports a bare repository. The same malformed value is accepted if the file ends with a newline.

Change

Keep tracking quotes through the last physical line of a continuation and discard an unfinished quoted value. Valid quoted continuations and unquoted trailing backslashes keep working.

Scope and approval

This is a small correction to the existing parser, addressing CodeRabbit’s remaining finding on #30174. It qualifies as a focused fix for an obvious bug. The change only affects malformed continued values.

Verification

Added two assertions to the existing shared parser test. The regression fails on upstream 8b44f42b14c8e273156474a924ccf29680dd7857 and passes with the fix. All 31 tests in that file pass.

Compared the parser with native Git across 30 LF/CRLF cases covering valid continuations, comments, unquoted EOF values, and unfinished quotes. All agree. For the malformed input above, git config --file <fixture> --type=bool --get core.bare exits 128 with fatal: bad config line 3; the parser previously returned true and now returns false. The newline-terminated form gives the same result.

vp run check:changed --concurrency 1 --timeout 240 origin/main passed formatting, lint, both Knip passes, typechecks for 34 packages, and all 32 selected tests. Used the pinned Node 26.12.1 and pnpm 12.14.0 after a frozen-lockfile install. Full build and test suites remain for CI.

Implemented with GPT-6 in OpenAI Codex.

[macroscopeapp]

Approvability

Verdict: Approved at a33a6da

Macroscope's review found this PR approvable — This change ignores unfinished quoted Git config continuations when detecting bare repositories. Its effect is limited to read-only repository classification during session scanning, with no changes to repository contents or product defaults.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

gitConfigLines now scans lines when a continuation is pending. It yields joined or final pending text only when quotes are closed. Tests cover quoted true values ending in a continuation backslash, with and without a trailing newline.

Changes: Git config continuation parsing

Layer / File(s)	Summary
Continuation and quote handling packages/shared/src/git.ts, packages/shared/src/git.test.ts	gitConfigLines scans lines while a continuation is pending and omits joined or final text when quotes remain open. Tests assert that isBareGitConfig returns false for quoted true values ending in a continuation backslash, with or without a trailing newline.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

• pingdotgg/t3code#30174: Added gitConfigLines and continuation handling, which this change updates.

Suggested labels: vouch:unvouched, size:S

Suggested reviewers: marcodotio, macroscopeapp

Merge Risk: Minimal · up to a33a6

The focused parser fix includes regression coverage for both newline forms and is mergeable with normal CI.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary change: ignoring unfinished quoted Git config continuations in the shared parser.
Description check		The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the bug, fix, scope rationale, regression tests, native Git comparison, and validatio…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the bug, fix, scope rationale, regression tests, native Git comparison, and validation results.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 8b44f42
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: ff00a3a2-3a5d-4c20-b6b5-d189b5ea82ea

Commits

Reviewing files that changed from the base of the PR and between 8b44f42 and a33a6da.

Files selected for processing: 2

• packages/shared/src/git.test.ts
• packages/shared/src/git.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified unchanged head a33a6da7762bce292db1e17f049975aeb86c4136 against github/main at 8b44f42b14c8e273156474a924ccf29680dd7857 on a disposable linux vm. installed dependencies and ran each checkout's real dev server sequentially. drove the web client with repository playwright and /usr/bin/google-chrome.

created a real git repository, linked worktree, project and thread, then completed a real codex gpt-6.1-sol turn through the web composer. no mocked provider or fabricated transcripts.

with the common config ending in bare = "true\, both with and without a final newline, main incorrectly offered quote-linked in "import your projects". the pr correctly excluded it using the same app-created session data.

nearby behavior passed: valid quoted continuations and unquoted trailing-backslash values still offered the linked worktree; normal bare = false excluded it. after restoring valid config, a follow-up codex turn ran pwd and git status --short and completed normally.

short runtime transcript:

malformed common config, both newline forms:
  git config --type=bool --get core.bare -> exit 128, bad config line 3
  main import wizard -> quote-linked present (incorrect)
  pr import wizard   -> quote-linked absent
valid quoted continuation / unquoted EOF continuation:
  git -> true; pr import wizard -> quote-linked present
restored ordinary config:
  git -> false; pr import wizard -> quote-linked absent
codex through pr web client:
  pwd -> /home/user/quote-linked
  git status --short -> no output
  assistant -> PR_QUOTE_VERIFY_OK
blacksmith: git.test.ts -> 31 passed
blacksmith: AgentSessionScanner.test.ts -> 65 passed

before, main:

after, pr:

Not verified

native ios/android, electron, macos/windows, remote relay/tunnel connections, and other providers were not exercised. verification used the linux web client and local codex proxy. no code changes were needed.