Repository navigation
Conversation
A good scan only filled Address and Code, leaving the user to tap Connect. The scan now pairs through the same path as Connect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Scanning a pairing QR code now starts pairing immediately rather than waiting for a separate submit action. Human review is needed to confirm this change to the default connection interaction. You can add or adjust custom eligibility rules. Learn more. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Scanning a pairing QR code in the mobile Add environment sheet only filled Address and Code. The user then had to tap Connect. The code was already valid and single-use, so the extra tap added nothing.
This has been the behavior since the screen's first version (#3514), where the scanner was an overlay that closed back onto the form. Later PRs, including the scan card redesign (#17092), kept it without discussing it.
Change
ConnectionsNewRouteScreen.tsx: a valid scan still fills the fields for display, then pairs straight away through the same path as Connect. That means the same spinner, haptics, expected-environment check and navigation on success. On failure the error appears in the card as before, so the user can edit and retry or scan again. A scan made while a connection is in progress doesn't start a second one.Recordings
Android emulator, scanning a
t3 pairQR code from the Add environment sheet.Verification
Model: Claude Opus 5.5 | Harness: Claude Code in T3 Code
🤖 Generated with Claude Code