Skip to content

fix(mobile): scanning a pairing QR code connects right away - #30343

Open
spadaval wants to merge 1 commit into
pingdotgg:mainfrom
spadaval:fix/mobile-qr-scan-connects
Open

spadaval wants to merge 1 commit into
pingdotgg:mainfrom
spadaval:fix/mobile-qr-scan-connects

Conversation

@spadaval

@spadaval spadaval commented Nov 3, 2026 •

Copy link
Copy Markdown

Problem

Scanning a pairing QR code in the mobile Add environment sheet only filled Address and Code. The user then had to tap Connect. The code was already valid and single-use, so the extra tap added nothing.

This has been the behavior since the screen's first version (#3514), where the scanner was an overlay that closed back onto the form. Later PRs, including the scan card redesign (#17092), kept it without discussing it.

Change

ConnectionsNewRouteScreen.tsx: a valid scan still fills the fields for display, then pairs straight away through the same path as Connect. That means the same spinner, haptics, expected-environment check and navigation on success. On failure the error appears in the card as before, so the user can edit and retry or scan again. A scan made while a connection is in progress doesn't start a second one.

Recordings

Android emulator, scanning a t3 pair QR code from the Add environment sheet.

Before: the scan fills the fields, then waits for ✓ After: the scan connects
Before: scan fills Address and Code, the sheet waits until the checkmark is tapped After: scan fills the fields, connects and closes the sheet
MP4 MP4

Verification

  • Format, lint, knip and changed-file tests pass. The mobile typecheck is clean.

Model: Claude Opus 5.5 | Harness: Claude Code in T3 Code

🤖 Generated with Claude Code

A good scan only filled Address and Code, leaving the user to tap Connect.
The scan now pairs through the same path as Connect.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Nov 3, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — Scanning a pairing QR code now starts pairing immediately rather than waiting for a separate submit action. Human review is needed to confirm this change to the default connection interaction.

You can add or adjust custom eligibility rules. Learn more.

@github-actions github-actions Bot added the size:XS 0-9 changed lines (additions + deletions). label Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant