Skip to content

fix(codex): explain speed limits on managed connections - #30322

Open
shivamhwp wants to merge 1 commit into
pingdotgg:mainfrom
shivamhwp:issue-watch/30245
Open

shivamhwp wants to merge 1 commit into
pingdotgg:mainfrom
shivamhwp:issue-watch/30245

Conversation

@shivamhwp

@shivamhwp shivamhwp commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Refs #30245.

The managed ChatGPT connection deliberately removes service-tier choices, but the model picker never explained why Fast was missing. Show the restriction in the web and desktop picker footer, explain the existing CLI route in mobile's sharing dialog, and document that route. This keeps the managed provider's tier guards in place.

The original managed-auth review required those guards: #14290 (comment). This change describes T3's current connection support; it does not establish whether OpenAI's sharing route now accepts Fast requests.

Validation at head cddfd94277a2ce227ab4493d4305c296b67bcd71, based on 7681605d7375cfa25e72ca48db56bb76e2025f7e:

  • vp run check:changed passed format, lint, both knip passes, affected typechecks (mobile, scripts, web), and React compiler checks. Its focused compiler verification reported 2 test files passed, 7 tests passed; the remaining 2312 tests were outside that selection. CI runs the full suites.
  • Independent Codex review found no issues. Macroscope and CodeRabbit found no actionable issues; required CI checks pass at this head. CI output.
  • Integrated browser pass on corex with an isolated server and sanitized, in-memory managed-provider fixture. Sol Extra High remains selectable; the explanation fits desktop and narrow widths. The existing CLI connection retains Standard/Fast.
  • Integrated iOS 27.0 pass on the pool iPhone 18 Pro, native fingerprint 887f84d7e8ee2e1063658bf884c9d17f60d6cbb3, with the committed JavaScript bundle and an isolated, sanitized in-memory fixture. The sharing status opens the full guidance in its existing dialog. This verifies the dialog, not managed catalog/network behavior.
  • macOS Electron verification blocked: shiv run r_m2f3aerc8jfw0000 at this head on macOS 27.0.1 arm64 had no T3 Browser panel tools. The repository test skill requires that panel and forbids switching automation systems. No macOS build or app was launched; baseline/final Electron captures remain unverified. The worker removed its temporary checkout and started no processes.
  • Not shown: an authenticated managed connection or Fast inference; no provider request behavior changes.

Before, the managed picker gave no speed explanation.
before

After, the same picker explains the restriction.
after

The explanation also fits a narrow window.
narrow window

On iOS, the existing sharing dialog previously gave no speed guidance.
iOS before

The same dialog now explains the restriction and existing CLI option.
iOS after

Implemented by Claude Opus 5.5 in T3 Code. Investigated, verified and reviewed by GPT-6.1 Sol in the Codex harness.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Nov 3, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at cddfd94

Macroscope's review found this PR approvable — Adds web, mobile, and documentation notices explaining speed limitations on ChatGPT-sharing connections. The change is informational and does not alter connection behavior or product defaults.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The ChatGPT sharing notices in mobile and web now state that Fast and Ultrafast are unavailable. The provider documentation also describes this limitation and points to existing Codex login instructions.

Changes: ChatGPT speed availability notices

Layer / File(s) Summary
Sharing notices and provider documentation
apps/mobile/src/features/threads/ChatGptSharingStatus.tsx, apps/web/src/components/chat/ChatGptSharingControl.tsx, docs/user/providers-codex.md
The mobile alert and web sharing control state that Fast and Ultrafast are unavailable with the ChatGPT connection. The documentation adds the same limitation and points to existing Codex login instructions.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related issues

  • pingdotgg/t3code issue 17856 — The PR adds an explanation of unsupported capabilities in sharing interfaces and documentation. It does not add managed accounts to Usage → Limits, as the issue summary notes.
  • pingdotgg/t3code issue 30245 — The PR explains that Fast and Ultrafast are unavailable and points to the existing CLI route described in the issue summary.

Suggested reviewers: macroscopeapp

Merge Risk: Minimal · up to cddfd

The notices explain the managed connection’s speed limitation. No merge-blocking issue was identified.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title "fix(codex): explain speed limits on managed connections" matches the main change. The PR adds explanations that Fast and Ultrafast are unavailable on the managed ChatGPT connection, in the …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is complete and covers the problem, implementation, scope and approval references, verification results, screenshots, limitations, and agent attribution. It is not organized under the …
Full details: Title check

Explanation

The title "fix(codex): explain speed limits on managed connections" matches the main change. The PR adds explanations that Fast and Ultrafast are unavailable on the managed ChatGPT connection, in the web/desktop picker, the mobile sharing dialog, and the docs. The title is short, uses a conventional commit format, and names the specific behavior. It does not mention the mobile or docs parts, but those are supporting aspects of the same change.

Full details: Description check

Explanation

The description is complete and covers the problem, implementation, scope and approval references, verification results, screenshots, limitations, and agent attribution. It is not organized under the template headings, but all required information is present.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1a3f76e and cddfd94.

Files selected for processing: 3
  • apps/mobile/src/features/threads/ChatGptSharingStatus.tsx
  • apps/web/src/components/chat/ChatGptSharingControl.tsx
  • docs/user/providers-codex.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

@github-actions github-actions Bot added the size:XS 0-9 changed lines (additions + deletions). label Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant