tidb-cloud: fix Terraform import ID formats for network container and private endpoint connection - #23992
tidb-cloud: fix Terraform import ID formats for network container and private endpoint connection#23992yahonda wants to merge 2 commits into
Conversation
… private endpoint connection Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: pingcap/docs/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[LGTM Timeline notifier]Timeline:
|
|
The corrected import ID formats look right, but the example import outputs later in both sections still use the old/invalid formats. Could we update them as part of this PR as well? Otherwise, each section gives users two conflicting import ID formats. |
…ted ID formats Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Updated the output ids. 73f9dd6 |
What is changed, added, or deleted? (Required)
Fixes the import ID formats in two Terraform resource docs. The documented formats do not match what the TiDB Cloud Terraform Provider accepts.
tidb-cloud/terraform-use-dedicated-network-container-resource.md: the doc says to replace${id}withcluster_id,network_container_id. The provider'sImportStatepasses the whole import ID through asnetwork_container_id:Readthen callsGetNetworkContainer(ctx, data.NetworkContainerId.ValueString()), so an import ID that contains acluster_id,prefix fails. The doc now says to use the network container ID.tidb-cloud/terraform-use-dedicated-private-endpoint-connection-resource.md: the doc sayscluster_id,dedicated_private_endpoint_connection_id(two parts). The provider requires three parts and rejects anything else:The doc now says
cluster_id,node_group_id,private_endpoint_connection_id.Source:
internal/provider/dedicated_network_container_resource.goandinternal/provider/dedicated_private_endpoint_connection_resource.gointidbcloud/terraform-provider-tidbcloud.This was flagged by CodeRabbit on the Japanese translation PR #23987, which inherited the same formats from EN.
Update (73f9dd6): the
terraform applyexample outputs later in both sections still showed the old import IDs. They now use the corrected formats, with the ID values that already appear on the same pages:[id=10423692645683000000,example]→[id=1934235512696000000](thenetwork_container_idvalue).[id=aws-1934187953894000000,example](andaws-19341879538940000000in theImport completeline, which also had a different digit count) →[id=10757937805044000000,1934178998036000000,1934214559409000000](thecluster_id,node_group_id, andprivate_endpoint_connection_idvalues).Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code