Skip to content

Fix: Remove superfluous note - #558

Merged
cmb69 merged 1 commit into
php:masterfrom
localheinz:fix/note
Jun 27, 2022
Merged

cmb69 merged 1 commit into
php:masterfrom
localheinz:fix/note

Conversation

@localheinz

@localheinz localheinz commented Jun 27, 2022 •

Copy link
Copy Markdown
Contributor

This pull request

  • removes a superfluous note

Slightly related to #499.

💁‍♂️ If we were consistent, we would have two options:

  • add a similar note to all other major versions that are end of life
  • remove this note

Before

See http://localhost:8080/eol.php:

CleanShot 2022-06-27 at 15 26 27@2x

After

See http://localhost:8080/eol.php:

CleanShot 2022-06-27 at 15 25 50@2x

@cmb69

cmb69 commented Jun 27, 2022

Copy link
Copy Markdown
Member

Makes perfect sense. Thank you!

@cmb69
cmb69 merged commit c40cac0 into php:master Jun 27, 2022
@localheinz
localheinz deleted the fix/note branch June 27, 2022 14:13
@localheinz

Copy link
Copy Markdown
Contributor Author

Thank you, @cmb69!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants