Skip to content

eol.php layout broken on mobile due to extra-wide table #498

Closed

Description

@SteveDesmond-ca

Steps to reproduce:

Expected result:

  • notes are legible

Observed result:

  • wide table breaks intended page layout
    Screen Shot 2022-02-24 at 12 40 17

Activity

  1. cmb69 commented on Feb 24, 2022

    @cmb69
    Member

    Oh, that dark bar at the right hand side is unlikely to be intended here. I also see it with wider viewports (about 950px).

  2. SteveDesmond-ca commented on Feb 24, 2022

    @SteveDesmond-ca
    ContributorAuthor

    Yeah, I see that too, between 768-979px; but I think that's a separate problem, where the sidebar shouldn't be shown if there's no aside. The width: 70% !important in the media query is overriding the :only-child selector which would otherwise have the main conent be full-width. Want me to create another issue for that one?

  3. derickr commented on Nov 29, 2023

    @derickr
    Member

    I can't reproduce this — there have been changes, so perhaps this is fixed?

  4. SteveDesmond-ca commented on Nov 29, 2023

    @SteveDesmond-ca
    ContributorAuthor

    Still there to some extent: shrink the browser's viewport to 320px wide and scroll right.
    Screen Shot 2023-11-29 at 12 17 44

    I believe the best fix at this point is to set the thead and "odd" rows' (2n+1) background-color to var(--content-background-color) instead of the default transparent.
    Screen Shot 2023-11-29 at 12 30 20

    table.standard tr:nth-child(2n+1) td, table.standard thead th {
      background-color: var(--content-background-color);
    }

    That said, the fix from #499 decreased the breaking width to 352px, and the vast majority of phones these days are wider than that, so I'd be willing to have this closed as "good enough" since very few people will still experience this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions