You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Convert homepage hero section styles to use BEM methodology #1102
The homepage hero section currently does not follow the BEM (Block Element Modifier) methodology that has been partially adopted in newer pages, such as the thanks page. The upcoming navbar and search modal will also follow BEM conventions. The hero section was initially implemented in PR #459, but now needs to be updated to align with these conventions.
Task
Update the CSS and structure of the homepage hero section to match the BEM conventions used elsewhere. Only the relevant portions of index.php and styles/home.css should be updated. Additionally, the visual tests references to the hero classes will need to be updated.
Example Conversion
Here’s an example to guide you in converting a class:
Current class:
.hero-btn-primary { ... }
Converted to BEM:
.hero__btn--primary { ... }
In this example:
.hero is the Block, representing the main component.
__btn is an Element, indicating a part of the block.
--primary is a Modifier, signifying a variation of the button.
Steps
Clone the repository and navigate to the homepage code.
Refactor the CSS classes in the hero section using the BEM naming convention. Focus only on the hero-related classes.
Ensure the CSS in styles/home.css follows BEM principles.
Update the relevant visual tests where hero classes are used.
Test the changes to ensure the styling and visual tests remain consistent.
Activity
lhsazevedo commentedon Oct 24, 2024
@saundefined Can you add
hacktoberfestandgood first issuelabels to this issue?saundefined commentedon Oct 24, 2024
done, thanks for the proposal!
nafisreza commentedon Oct 25, 2024
/assign
lhsazevedo commentedon Oct 25, 2024
@nafisreza Sure, go ahead! Someone will assign this to you shortly.
If you decide not to work on it, please let us know so that someone else can take it up.
nafisreza commentedon Oct 25, 2024
Thanks @lhsazevedo
I am starting to work on this.