Skip to content

Support building when package is not in the root directory #84

Closed

Description

@asgrim

From @zeriyoshi - original proposal in #82

Add extension-src directive to the php-ext section in composer.json.

This enables support for patterns where extension source code is not located in the project root, which is commonly seen in third-party extensions.

https://github.com/protocolbuffers/protobuf/tree/main/php/ext/google/protobuf

{
    "name": "google/protobuf",
    "type": "php-ext",
    "description": "protocolbuffers php extension",
    "php-ext": {
        "extension-name": "protobuf",
        "extension-src": "php/ext/google/protobuf"
    }
}

Investigate options, check this makes sense and is clear. Documentation would be needed, and upstream Composer schema support.

Activity

  1. self-assigned this
    on Nov 7, 2024
  2. asgrim commented on Nov 7, 2024

    @asgrim
    ContributorAuthor

    I will revisit this after #83 is merged

  3. macintoshplus commented on Nov 19, 2024

    @macintoshplus
    Contributor

    @asgrim This option can specify the name of the extension DLL?

    Other automated scripts already use the zip attached on the GitHub release to install an extension automatically. It's hard to change the dll name into the zip archive without breaking something.

  4. asgrim commented on Nov 19, 2024

    @asgrim
    ContributorAuthor

    @asgrim This option can specify the name of the extension DLL?

    Other automated scripts already use the zip attached on the GitHub release to install an extension automatically. It's hard to change the dll name into the zip archive without breaking something.

    This is an entirely separate issue

  5. asgrim commented on Nov 19, 2024

    @asgrim
    ContributorAuthor

    @zeriyoshi I gave this some thought, I think build-path may be a better name for this.

    ThePHPF/pie-design#28

    If there is no further feedback, please leave it with me, I have a PR updated and also will send a patch upstream to Composer.

  6. zeriyoshi commented on Dec 2, 2024

    @zeriyoshi
    Contributor

    Sorry, I missed this one. I don't think it's a problem.

  7. added this to the 0.3.0 milestone on Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions