Repository navigation
Conversation
Member
Author
|
@arnaud-lb I forgot that this depends on GH-9473. The forked process does not clean up memory which Clang reports as leaks. Skipping the fork avoids this issue. Do you think GH-9473 can be backported? I don't see any issues with it. For context, Bob asked for ASAN in PRs for PHP 8.2. |
Member
|
Sure, I will take a look on Friday |
Member
Author
|
@arnaud-lb I can just cherry-pick it here. 🙂 I was just asking if you see any issues with that. @ramsey Would you be ok with cherry-picking #9473 for PHP-8.2 too? |
Member
Author
|
PHP-8.2 is not mostly "frozen", so this makes less sense. Bugs will target 8.1 which would still not get this pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.