Skip to content

Fixed bug #62202 (ReflectionParameter::getDefaultValue() leaks with constand - #97

Closed
reeze wants to merge 1 commit into
php:PHP-5.3from
reeze:fix-getDefaultValue-const-leak
Closed

reeze wants to merge 1 commit into
php:PHP-5.3from
reeze:fix-getDefaultValue-const-leak

Conversation

@reeze

@reeze reeze commented Jun 1, 2012

Copy link
Copy Markdown
Contributor

Hi,
I found this leaks when testing reflection related functions.

This happend because when compiling constant zval.type will add IS_CONSTANT_UNQUALIFIED.

Thank:)

@laruence

laruence commented Jun 1, 2012

Copy link
Copy Markdown
Member

why my comment disappeared? what did you do?

@reeze

reeze commented Jun 1, 2012

Copy link
Copy Markdown
Contributor Author

it lost when I force-updated the PR,
because I want to update the zval_type to type to make it short and clean.
It's still in here reeze@34407d9#commitcomment-1402443
but this commit is not connected with this PR anymore so It dispeared in this conversation :(

@laruence

laruence commented Jun 1, 2012

Copy link
Copy Markdown
Member

thanks for spotting this issue, however I got another fix, committed here: 1f5327a

thanks

@php-pulls

Copy link
Copy Markdown

Comment on behalf of laruence at php.net:

another fix has beend committed, closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants