Repository navigation
Conversation
|
Why is moving all these files needed? |
|
it is not needed, but some CI directories are prefixed with dot, some not, this unifies the file structure |
|
Then please keep them as is. |
c37298c to
c70e625
Compare
the intention is to separate CI files/directories more which is quite common and helpful for quick orientation in the file structure, would you be fine with prefixing the CI directories (and unifying with |
I know Git can sometimes recognize renames but it has still been a pain for me in the past, so I think we should keep this as is. |
707d6cf to
1c588ed
Compare
This reverts commit 8db6965.
bb96c0a to
56110d3
Compare
|
@iluuu1994 the MacOS CI error is unrelated, can you please do a final review and if all ok, please squash and merge |
iluuu1994
left a comment
There was a problem hiding this comment.
Thank you! I'll merge this soon.
|
@iluuu1994 is soon now? :) |
|
Merged as b43e494. Note: In PHP-8.2 appveyor/setup_hmailserver.php was added so we might want to move that one too. |
|
Thank you, I added your comment about hmailserver into #9650. I would like to add Windows 32 bit testing as well. Almost everything is done, but #9650 is blocking the PR, as it causes like every 3rd CI run or so to fail. Do you have any idea what can be the problem and do you have access to Windows to run like hundred of full testing cycles of x86/32 bit build to reproduce? |
|
I don't have a Windows machine so I can't help there. Apparently MSVC now has a address sanitizer, you could try that. https://devblogs.microsoft.com/cppblog/address-sanitizer-for-msvc-now-generally-available/ |
See #6964 |
isolated from #8392 PR, these changes are mostly renames
before merge, please squash into one commit