Repository navigation
Do not require opcache.preload_user in cli SAPIs - #9515
Merged
Merged
Conversation
arnaud-lb
changed the title
arnaud-lb
force-pushed
the
preload_user_not_required
branch
from
September 9, 2022 14:27
a605261 to
127ea5c
Compare
arnaud-lb
marked this pull request as ready for review
September 23, 2022 11:29
Member
Author
|
This one may be a bit hard to review, sorry about that. The diff may be easier when ignoring whitespaces. The first commit reorganizes accel_finish_startup() to make it easier to introduce the change. |
iluuu1994
reviewed
Sep 29, 2022
| opcache.enable_cli=1 | ||
| opcache.optimization_level=-1 | ||
| opcache.preload={PWD}/preload_user.inc | ||
| opcache.preload_user={ENV:TEST_NON_ROOT_USER} |
Member
There was a problem hiding this comment.
I can't actually see this env variable anywhere, is this actually set?
Member
Author
There was a problem hiding this comment.
That's right, I will have to define this variable in builds if this is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #9473:
opcache.preload_userdoes not have to be required when the SAPI executes requests and startup as the same user.This PR changes
opcache.preload_userso that it's not required under cli and phpdbg SAPIs.