Repository navigation
Conversation
…uct to __int64 is unsafe. via http://technet.microsoft.com/en-us/library/ms724284(v=vs.85).aspx "Do not cast a pointer to a FILETIME structure to either a ULARGE_INTEGER* or __int64* value because it can cause alignment faults on 64-bit Windows."
Member
|
@pierrejoye can you take a look at that please. |
|
Comment on behalf of laruence at php.net: merged |
php-pulls
pushed a commit
that referenced
this pull request
Jun 15, 2014
zend_hash_get_current_key_zval_ex isn't defined in PHP 5.4. (used in phpdbg_watch.c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The direct convert from FILE struct to __int64 is unsafe.
via http://technet.microsoft.com/en-us/library/ms724284(v=vs.85).aspx
"Do not cast a pointer to a FILETIME structure to either a
ULARGE_INTEGER* or __int64* value because it can cause alignment faults on 64-bit Windows."
In my computer(windows 7 32bit), either way works fine. but i just believe it's necessary to avoid the Possible problems .
long long getfilesystemtime_old()
{
FILETIME ft;
__int64 ff;
ULARGE_INTEGER convFromft;
GetSystemTimeAsFileTime(&ft);
ff = _(_int64)(&ft);
return ff;
}
long long getfilesystemtime()
{
FILETIME ft;
__int64 ff;
ULARGE_INTEGER convFromft;
GetSystemTimeAsFileTime(&ft);
convFromft.HighPart=ft.dwHighDateTime;
convFromft.LowPart=ft.dwLowDateTime;
ff=convFromft.QuadPart;
}
int _tmain(int argc, _TCHAR* argv[])
{
if(getfilesystemtime()==getfilesystemtime_old())
{
printf("good");
}
}