Skip to content

Fix GH-8848: imagecopyresized() error refers to the wrong argument #8849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmb69 wants to merge 1 commit into from
Closed

Fix GH-8848: imagecopyresized() error refers to the wrong argument #8849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ext/gd/gd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3013,22 +3013,22 @@ PHP_FUNCTION(imagecopyresized)
dstW = DW;

if (dstW <= 0) {
zend_argument_value_error(3, "must be greater than 0");
zend_argument_value_error(7, "must be greater than 0");
RETURN_THROWS();
}

if (dstH <= 0) {
zend_argument_value_error(4, "must be greater than 0");
zend_argument_value_error(8, "must be greater than 0");
RETURN_THROWS();
}

if (srcW <= 0) {
zend_argument_value_error(5, "must be greater than 0");
zend_argument_value_error(9, "must be greater than 0");
RETURN_THROWS();
}

if (srcH <= 0) {
zend_argument_value_error(6, "must be greater than 0");
zend_argument_value_error(10, "must be greater than 0");
RETURN_THROWS();
}

Expand Down
31 changes: 31 additions & 0 deletions ext/gd/tests/gh8848.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
--TEST--
GH-8848 (imagecopyresized() error refers to the wrong argument)
--SKIPIF--
<?php
if (!extension_loaded("gd")) die("skip gd extension not available");
?>
--FILE--
<?php
$image1 = imagecreatetruecolor(1, 1);
$image2 = imagecreatetruecolor(1, 1);

$argslist = [
[0, 1, 1, 1],
[1, 0, 1, 1],
[1, 1, 0, 1],
[1, 1, 1, 0],
];

foreach ($argslist as $args) {
try {
imagecopyresized($image1, $image2, 1, 1, 1, 1, ...$args);
} catch (ValueError $ex) {
echo $ex->getMessage(), PHP_EOL;
}
}
?>
--EXPECT--
imagecopyresized(): Argument #7 ($dst_width) must be greater than 0
imagecopyresized(): Argument #8 ($dst_height) must be greater than 0
imagecopyresized(): Argument #9 ($src_width) must be greater than 0
imagecopyresized(): Argument #10 ($src_height) must be greater than 0