Repository navigation
Add AllowDynamicProperties on OCILob and OCICollection - #8844
Merged
Merged
Conversation
cmb69
approved these changes
Jun 22, 2022
cmb69
left a comment
cmb69
left a comment
Member
There was a problem hiding this comment.
Thank you!
Looks like a sensible stop-gap measure to me.
TimWolla
reviewed
Jun 22, 2022
Fix phpGH-8756 : oci_new_descriptor() triggers dynamic property deprecation. This fix should be temporary. At some point we should either define those properties or just hide them since they should probably not be used. Better fix is here : php#8758 but waiting feedback from Oracle team before going ahead.
Contributor
|
Thank you @adoy! |
|
It doesn't work anymore. Error occurs again. PHP Version 8.2.4 based on php:8.2.4-apache-bullseye |
Member
Author
|
I'm a little bit busy those days but I'll have a look prior 8.2.6 (Too late for 8.2.5). |
|
Thank you very much! |
Member
Author
|
@BigOHenry I moved the discussion to the original issue #8756 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GH-8756 : oci_new_descriptor() triggers dynamic property
deprecation.
This fix should be temporary. At some point we should either define
those properties or just hide them since they should probably not be
used.
Better fix is here : #8758 but
waiting feedback from Oracle team before going ahead.