[alexdowad]

As requested in #8439.

@cmb69 @mvorisek @icetee @ramsey

@mvorisek You mentioned that historically, Czech has used Windows-1250 encoding. I have no objection to adding support for Windows-1250 to mbstring, if it is likely that Eastern European PHP users will actually use it. If nobody is likely to use it, it will be better to leave it out.

[mvorisek]

@mvorisek You mentioned that historically, Czech has used Windows-1250 encoding. I have no objection to adding support for Windows-1250 to mbstring, if it is likely that Eastern European PHP users will actually use it. If nobody is likely to use it, it will be better to leave it out.

In some legacy Windows applications, it is still used in the Czech Republic, but I personally do not need it.

[alexdowad]

I guess I can take @cmb69's "thumbs up" as approval? 😄

[cmb69]

My thumbs-up was primarily regarding your stance on Windows 1250 support, especially to add it, if it's actually needed. But anyhow, it was fine to merge this PR. :)

[ramsey]

This says it was merged directly into master, so how did 58d0aad get into PHP-8.1? Did you cherry-pick it there after merging to this to master?

[alexdowad]

This says it was merged directly into master, so how did 58d0aad get into PHP-8.1? Did you cherry-pick it there after merging to this to master?

No, I merged into PHP-8.1 first and then merged PHP-8.1 down into master.

The message displayed by GitHub is not correct.

[cmb69]

This is due to GH's focus on the default branch (that doesn't quite match our branching strategy).

[ramsey]

Thanks. It was very confusing. 😄