Repository navigation
Cleanup useless function declaration for traits - #81
Merged
Merged
Conversation
Member
|
merged, but I can not see this PR in control panel where I could close this, could you please colse this PR yourself? |
Member
|
oh,,, seems the git-pull do it automatically. ignore me.... |
Contributor
Author
|
thanks ：） Reeze On 2012年5月11日Friday at 20:31, Xinchen Hui wrote:
|
php-pulls
pushed a commit
that referenced
this pull request
Apr 21, 2014
heyJordanParker
referenced
this pull request
in heyJordanParker/php-sharp
Oct 9, 2026
Problem: The engine was pinned to Mago e424429d4, a master commit between releases. mago-sharp 0.2.0 is now released at 98d123849, and it carries #81, which rewords the checker's PHP# messages: a nullable ordering operand is named NullableOperand, paradox reports name variables and types the way PHP# writes them, and notes state their reason instead of citing spec sections. A php-sharp release has to name the checker release its .sharpc files come from. Solution: - sharp_unit.h is the header Mago 98d123849 generates. Only SHARP_MAGO_COMMIT moves. sharp_kind, the SHARP_T_ tokens and SHARP_UNIT_ABI stay the same, so the engine reads the same .sharpc layout and every compiled file stays current. - No php-sharp test expects a text #81 moved: compile_command.phpt passes unchanged, and no test, doc or spec line names a spec section or the old wordings. ext/sharp/ └── sharp_unit.h <- SHARP_MAGO_COMMIT 98d123849b6d27a836c1d4f64d4515d2f1e8f78f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'v noticed that those three function declearation was unused.
@smarr 's original patch http://www.stefan-marr.de/traits/traits.patch didn't use them either.
so I made a patch to remove them.
void init_trait_alias_list(znode* result, const znode* trait_alias TSRMLS_DC);
void add_trait_alias(znode* result, const znode* trait_alias TSRMLS_DC);
void init_trait_alias(znode* result, const znode* method_name, const znode* alias, const znode* modifiers TSRMLS_DC);
Those function's are replaced by the zend_init_list() && zend_add_to_list();
Thanks.