[cmb69]

enchant_broker_list_dicts() and enchant_broker_describe() return
null if no broker is available.

---

Alternatively, we could change the implementation to return an empty array in this case.

[cmb69]

@remicollet, what do you think?

[nikic]

Does it really return null? PHP_ENCHANT_GET_BROKER returns false if no broker available (it should throw instead).

[cmb69]

return_value is only initialized inside of the callback which traverses the brokers/dicts. If there are none, the callback is never executed, so return_value stays undefined.

[nikic]

@cmb69 I see. In that case I'd say this definitely should array_init(return_value) beforehand.

[remicollet]

@cmb69 I agree with your PR, change NULL to empty array may be a BC break.

@nikic yes PHP_ENCHANT_GET_BROKER could raise an exception, but this only happens is user call enchant_broker_free-*, thus the reason why I deprecate these in pr #5528

[remicollet]

@cmb69 I merged this PR in mine

@nikic in pr #5528 invalid object now raise an exception

[nikic]

@cmb69 I agree with your PR, change NULL to empty array may be a BC break.

It's ok for PHP 8.

[cmb69]

I agree that the minor BC break would be acceptable for PHP 8, especially since this is only relevant if the extension is not really usable (i.e. has no brokers or dicts). On the other hand, I think sticking with ?array is also okay.

Anyhow, @remicollet has incorporated this in PR #5528, so this PR can be closed.

[nikic]

This issue does not seem related to the object migration, so it would be preferable to address it independently.

[cmb69]

Okay, makes sense. @remicollet, could you please revert these changes from PR #5528.

[remicollet]

Applied in c1ad916