Skip to content

Changed proc_open() zpp argument to separate the environment array - #487

Closed
datibbaw wants to merge 4 commits into
php:masterfrom
datibbaw:bug60602
Closed

datibbaw wants to merge 4 commits into
php:masterfrom
datibbaw:bug60602

Conversation

@datibbaw

Copy link
Copy Markdown
Contributor

This fixes https://bugs.php.net/bug.php?id=60602

The convert_to_string_ex() was modifying the underlying array while creating the environment string, so I've tweaked the respective zpp argument.

@nikic

nikic commented Oct 10, 2013

Copy link
Copy Markdown
Member

Why does ! fix this bug? Do you maybe mean /? But in any case, I'd prefer to change the string cast (copy to local zval + convert_to_string) rather than doing a full zval separation on the array here.

@datibbaw datibbaw closed this Oct 10, 2013
@datibbaw datibbaw reopened this Oct 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants