Skip to content

Assume the free space is correct on Travis CI. - #484

Closed
datibbaw wants to merge 1 commit into
php:masterfrom
datibbaw:diskfree-test
Closed

datibbaw wants to merge 1 commit into
php:masterfrom
datibbaw:diskfree-test

Conversation

@datibbaw

@datibbaw datibbaw commented Oct 9, 2013

Copy link
Copy Markdown
Contributor

As discussed on the list here, Travis build machines are heavily loaded and as such testing to see whether disk space decreases after writing a file is not reliable.

This change will fake success on Travis CI based off the TRAVIS environment variable.

@m6w6

m6w6 commented Oct 17, 2013

Copy link
Copy Markdown
Contributor

Merged as 51b809e in PHP-5.5

@m6w6

m6w6 commented Oct 21, 2013

Copy link
Copy Markdown
Contributor

+1; I'll patch that test in 5.4 upwards -- once and for all

@php-pulls

Copy link
Copy Markdown

Comment on behalf of kaplan at php.net:

Already merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants