Skip to content

Bug 64560 - #471

Closed
bor0 wants to merge 1 commit into
php:masterfrom
bor0:bug64560
Closed

bor0 wants to merge 1 commit into
php:masterfrom
bor0:bug64560

Conversation

@bor0

@bor0 bor0 commented Sep 25, 2013

Copy link
Copy Markdown
Contributor

https://bugs.php.net/bug.php?id=64560

Include all timezones (with backwards compatibility) for default $what

Include all timezones (with backwards compatibility) for default $what
@hopeseekr

Copy link
Copy Markdown

I second this! Why the hell aren't very popular/important time zones like CST6CDT or EST5EDT included, for crying out loud?? It works for php.ini and date(), why not DateTime?

Comment thread ext/date/php_date.c

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! The hypocrisy of it all has caused me to fork my servers' own version of PHP just to have this functionality ;-)

@derickr

derickr commented Sep 22, 2014

Copy link
Copy Markdown
Member

This patch should not be merged. The exclusion of outdated timezones should not be in the default list because people should not be using them.

And that is even more true for "timezones" like "CST6CDT" as they do not do correctly what you think they would do.

@derickr derickr closed this Sep 22, 2014
@hopeseekr

Copy link
Copy Markdown

There's still the issue that the change 1) broke backward compatibility, 2) occurred in a MINOR revision of 5.4, and 3) was NEVER announced in the changelog.

Oh, and the fact that it breaks hard (critical error) on existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants