Repository navigation
Conversation
Contributor
|
I don't think it is a good idea. The standard properties should still be protected. If we need to expand it then we should check against the list of standard properties, for example. |
Contributor
Author
|
What standard properties did you have in mind? As far as I can see, this class only has EXCLUDE_START_DATE as a property. Did you mean about that one only? |
Contributor
|
As far as I can see from date_object_get_properties_period, there are at least 6 properties it supports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=65672
Removed function overload for write for DatePeriod.