Repository navigation
Conversation
Member
|
@petk Any data on php_error_docref0 use in extensions? |
Member
Member
Author
I'll make some PRs for those two extensions. Thanks for the info :) Edit: Done. |
This was referenced Jul 12, 2019
nikic
approved these changes
Jul 12, 2019
nikic
left a comment
Member
There was a problem hiding this comment.
Thanks for checking. In that case I think this is okay.
Member
|
Notice that this change breaks ABI |
Member
|
@remicollet -> #4470 |
This was referenced Jan 4, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits #4254
Takes the rather straight forward conversion of
php_error_docref0()tophp_error_docref()and remove the define inphp.h