Repository navigation
PHPTests for the DOMDocument::load and DOMDocument::loadXML - #359
dejalatele wants to merge 3 commits into
Conversation
tests for error1: not well formed xml tests for error2: not well formed xml attribute without colon tests for error2: not well formed xml, typo tests for error4: wrong xml version tests for error5: extra content at the end of the doc tests libxml_dtd_load tests libxml_dtd_valid tests for libdtd_noerror tests for LIBXML_DTDATTR, LIBXML_NOCDATA, LIBXML_NOENT and LIBXML_NOBLANKS the basic behavior fix comments
|
Three of those fail for me: Test DOMDocument::loadXML() with LIBXML_DTDLOAD option [ext/dom/tests/DOMDocument_loadXML_variation1.phpt] with messages like: Notice: DOMDocument::loadXML(): failed to load external entity "/Users/smalyshev/php-5.4/books.dtd" in Entity, line: 2 in /Users/smalyshev/php-5.4/ext/dom/tests/DOMDocument_loadXML_variation1.php on line 8 Seems that some chdir or something like that is missing. |
…directory for the php source code. It fixs the fail on the load of the dtd in the tests modified by this commit.
|
I've fix it with the commit above. |
|
@dejalatele I'm not sure it will always fix it - are you sure current dir is always PHP root dir? tests can be run from anywhere. |
|
@smalyshev I've fixed this issue in the last commit |
|
Comment on behalf of stas at php.net: merged |
3 participants
The tests cover the following cases for both methods: