Repository navigation

Typed Properties - #3313

Closed

nikic wants to merge 420 commits into

php:masterfrom

bwoebi:typed_ref_properties

Closed

Typed Properties#3313
nikic wants to merge 420 commits into
php:masterfrom
bwoebi:typed_ref_properties

This pull request is big! We're only showing the most recent 250 commits

Commits on May 25, 2016
- Reverted incomplete fix
  dstogov
  committed
  03861bd
- Fixed test
  dstogov
  committed
  be071cd
- A better to fix for source zval separation on type conversion caused by weak property type check.
  dstogov
  committed
  c992fcf
- Changed behavior of uninitialized nullable properties (accoding to conversation with Joe)
  dstogov
  committed
  f4b4051
- Revert useless changes
  dstogov
  committed
  e657bf8
- Removed useless check (references are never fetched using FETCH_OBJ_RW)
  dstogov
  committed
  d46695d
- Removed duplicate code
  dstogov
  committed
  a53b8ac
- Added support for nullavle types in AST pretty printer
  dstogov
  committed
  d248c27
- Revert useless change
  dstogov
  committed
  e1017f9
- Added test (memory leaks)
  dstogov
  committed
  291d431
- "string" mat be also a valid "callable"
  dstogov
  committed
  40aa6c2
- Removed unused function and macro
  dstogov
  committed
  3143597
- Optimization
  dstogov
  committed
  4506a70
- Removed unused zend_object_fetch_property_type_info() and renamed zend_object_fetch_property_type_info_ex() into zend_object_fetch_property_type_info()
  dstogov
  committed
  05dd2e4
- Fixed wrong exception when passing element of typed property by reference.
  dstogov
  committed
  023df77
- Optimisation
  dstogov
  committed
  56e2aaa
- Added test (failed with valgrind)
  dstogov
  committed
  d7f313e
- Added test (failed with valgrind)
  dstogov
  committed
  892994d
- Fixed memory leak
  dstogov
  committed
  b0dcf0c
- Check type after constant resolution
  dstogov
  committed
  2019f66
- Support for type checks of named constants in property default values.
  dstogov
  committed
  c304c6b
Commits on May 26, 2016
- Fixed memory leaks
  dstogov
  committed
  b2cebf6
- Faster +=/++/--
  dstogov
  committed
  8bc2078
- Merge branch 'master' into typed-properties
  dstogov
  committed
  26bf822
- Fixed ZTS compatibility
  dstogov
  committed
  865686f
- Fixed compilation warning
  dstogov
  committed
  bf875fb
- fixed white-spaces
  dstogov
  committed
  fc41cdc
- Optimization
  dstogov
  committed
  8beea3d
- Cleanup ext/reflection changes
  dstogov
  committed
  13c86d9
- Moved BG(unserialize_refs) into php_unserialize_data_t
  dstogov
  committed
  697b1b1
- Keep GCC from incorrect over-optimisation
  dstogov
  committed
  c5e45ff
Commits on May 27, 2016
- Removed useles code (default value should be already properly set in trait property)
  dstogov
  committed
  6bb1fa9
- Don't mess NULL and UNDEF default value back and force. Set proper value in first place.
  dstogov
  committed
  5811e86
- Remove duplicate checks
  dstogov
  committed
  037da58
- Fixed incorrect argument types
  dstogov
  committed
  03e7112
Commits on May 28, 2016
- Remove bad checks for simple property inheritance
  bwoebi
  committed
  cc19dc5
Commits on Jun 7, 2016
- Merge branch 'master' of https://github.com/php/php-src into typed-properties
  krakjoe
  committed
  3bbe52d
- changes prompted by review
  krakjoe
  committed
  de84f50
- make consistent with RFC (nullables)
  krakjoe
  committed
  71cda1b
- fix inheritance error
  krakjoe
  committed
  8eec27f
Commits on Nov 6, 2016
- Merge branch 'master' into typed_properties
  bwoebi
  committed
  67ffff9
Commits on Nov 13, 2016
- Initial ref types patch
  bwoebi
  committed
  1b8bd88
- Fix make test
  bwoebi
  committed
  0efa68b
- Take properly care of cases where the by-ref value is *consumed* first
  bwoebi
  committed
  a75e03a
- Remove all the nice code making it actually worse again ...
  bwoebi
  committed
  433e637
- Use reftype, not its location...
  bwoebi
  committed
  f4ea705
- few changes for bob to check
  krakjoe
  committed
  ad85b55
- Merge branch 'typed_ref_properties' of https://github.com/bwoebi/php-src into typed_ref_properties
  krakjoe
  committed
  c347d8d
- more zpp changes
  krakjoe
  committed
  2769866
- finish pcntl, probably
  krakjoe
  committed
  8d3a9f6
- some of sockets
  krakjoe
  committed
  d7c7b9c
- more zpppppp stuff
  krakjoe
  committed
  cd32f63
- use macros that actually exist, rather than nonsense
  krakjoe
  committed
  a0aaeed
Commits on Nov 14, 2016
- Fix a ton of bugs and tests
  bwoebi
  committed
  93707d7
Commits on Nov 18, 2016
- Add more guards for typed by-ref assign + fixes
  bwoebi
  committed
  bb230fd
- Fix a few more tests
  bwoebi
  committed
  38583b9
- typo; s/zend_get_long/zval_get_long/
  bwoebi
  committed
  fea2aa8
Commits on Nov 19, 2016
- Fix iterator_035.phpt and pcntl/003.phpt
  bwoebi
  committed
  d9b964e
- Remove lchown($file, -5); test
  bwoebi
  committed
  0cc95b8
- Merge branch 'master' into typed_ref_properties
  bwoebi
  committed
  694752b
- Add support for by-ref foreach
  bwoebi
  committed
  d5b3bd8
Commits on Dec 5, 2016
- Separate static property assignment out into dedicated assign ops
  bwoebi
  committed
  0bf02dc
Commits on Dec 7, 2016
- Merge remote-tracking branch 'origin' into typed_ref_properties
  bwoebi
  committed
  4c57735
Commits on Dec 9, 2016
- Fixed optimizer support for ZEND_ASSIGN_OBJ_REF
  dstogov
  committed
  786d4bb
- Implemented type inference support for typed properties.
  dstogov
  committed
  a9b0cd7
Commits on Jan 9, 2017
- Merge branch 'master' into typed_ref_properties
  bwoebi
  committed
  41d3882
- Merge remote-tracking branch 'github/typed_ref_properties' into typed_ref_properties
  bwoebi
  committed
  3e9d02e
Commits on Jan 10, 2017
- Fixed tests (made them 32/64-bit independent)
  dstogov
  committed
  f56bd39
Commits on Jan 11, 2017
- Fix a bunch of bugs related to e8109e09
  bwoebi
  committed
  354c1af
Commits on Jan 13, 2017
- Merge branch 'master' into typed_ref_properties
  dstogov
  committed
  69c7210
Commits on Jan 15, 2017
- Merge branch 'master' of https://github.com/php/php-src into typed_ref_properties
  bwoebi
  committed
  f2872c9
- Fix crash in pcntl_wait()
  bwoebi
  committed
  e20a1a3
Commits on Jan 16, 2017
- Merge branch 'master' into typed_ref_properties
  dstogov
  committed
  b021ec8
- Fix constant value overwrite
  bwoebi
  committed
  629521e
- Add support for iterable typed properties
  bwoebi
  committed
  78dae20
Commits on Jun 6, 2018
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  bafcfc0
- Fix build failures
  nikic
  committed
  965f2c8
- Initial ref type in MAKE_REF_EX
  nikic
  committed
  f42495d
Commits on Jun 7, 2018
- Solve the clashing FETCH_REF|CACHE_SLOT
  bwoebi
  committed
  ed00f11
- Fix few tests
  bwoebi
  committed
  6709fbb
Commits on Jun 8, 2018
- Fix cache_slot of ASSIGN_OBJ_REF
  bwoebi
  committed
  f55663f
- Opcache fixes
  bwoebi
  committed
  6d0c443
- Fix build failure in exif
  bwoebi
  committed
  c453c98
- Add one more test for iterables by ref
  bwoebi
  committed
  64a309f
- Fix foreach object iteration with holes
  bwoebi
  committed
  98019a9
Commits on Jun 9, 2018
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  e74f89c
- Restore old code for post_incdec as well
  nikic
  committed
  83ec0df
- Adjust test with new behavior
  nikic
  committed
  7f59681
- Fix compiler warning
  nikic
  committed
  1b0bc33
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  fcba7fe
- Improve default value handling
  nikic
  committed
  2e28eb6
- Allow int default value for float properties
  nikic
  committed
  4473554
- Use not_in_object_context helper
  nikic
  committed
  4ef0626
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  14081d8
- Fix ASSIGN_OBJ_REF implementation
  nikic
  committed
  cb75a25
Commits on Jun 11, 2018
- Don't automatically initialize nullable prop to null
  nikic
  committed
  3021bbc
Commits on Jun 12, 2018
- Forbid callable type hint in typed properties
  nikic
  committed
  230142e
Commits on Jun 13, 2018
- Merge branch 'extra_static_prop_assign_ops' into typed_ref_properties
  bwoebi
  committed
  b3da284
- Merge branch 'typed_ref_properties' of https://github.com/bwoebi/php-src into typed_ref_properties
  bwoebi
  committed
  b707745
Commits on Jun 14, 2018
- Add support for typed static properties (no opcache yet)
  bwoebi
  committed
  759d078
- Fix assign to typed ref with weak type conversion
  bwoebi
  committed
  ea58600
- Fix opcache for typed static properties
  bwoebi
  committed
  149fd4b
- Fix remaining tests
  bwoebi
  committed
  bb0e169
Commits on Jun 15, 2018
- Fixing conversion with __get() on uninit typed properties
  bwoebi
  committed
  ddfa19d
- Prevent constant propagation into ASSIGN_*_REF OP_DATA
  bwoebi
  committed
  8e23778
- Add ZEND_PRE/POST_INC/DEC_STATIC_PROP
  bwoebi
  committed
  fffb439
- Property compute intersection types for $obj->prop =& $ref
  nikic
  committed
  17bdcef
- Add missing test file...
  nikic
  committed
  40079bf
- Fix leak
  nikic
  committed
  bc900ea
Commits on Jun 16, 2018
- $a->b = $c must return (string) $c if $a->b is of type string
  bwoebi
  committed
  a450c28
- Drop overeager assert
  nikic
  committed
  ebb64ae
Commits on Jun 17, 2018
- Enforce reference checks on ReflectionClass::setStaticPropertyValue() + test
  bwoebi
  committed
  7c96afa
- Use coercive mode for setStaticPropertyValue()
  bwoebi
  committed
  10ac526
Commits on Jun 18, 2018
- Keep track of reference types
  bwoebi
  committed
  452d0a7
Commits on Jun 19, 2018
- Fix memory leaks & stupid bugs introduced in last commit
  bwoebi
  committed
  0023518
- Fix static property ref assignment without types
  bwoebi
  committed
  c69f8d0
Commits on Jun 20, 2018
- extract() must check typed refs when overwriting
  bwoebi
  committed
  f00a4df
- Mark subpats as ARRAY_ASSIGNABLE
  nikic
  committed
  1228d70
- Use TRY_ASSIGN_LONG for zcount parameters
  nikic
  committed
  440a78a
- Fix refcounting of zend_try_assign()
  bwoebi
  committed
  c6f5f13
Commits on Jun 21, 2018
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  df4460e
- Enforce reference type in settype()
  nikic
  committed
  693a603
- Make ZEND_TRY_ASSIGN_* implementation less magic
  nikic
  committed
  2d47e84
- Unmangle property name before printing
  nikic
  committed
  f6ad85f
Commits on Jun 22, 2018
- Fix reference type tracking on clone
  bwoebi
  committed
  898cd3d
Commits on Jun 25, 2018
- Merge branch 'master' of https://github.com/php/php-src into typed_ref_properties
  bwoebi
  committed
  5ce6ebc
- Update extensions for ZEND_TRY_ASSIGN_*
  nikic
  committed
  767b2e5
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  13eba68
Commits on Jun 27, 2018
- Opcache handling fixes and improvements
  nikic
  committed
  a3f60c0
- Merge remote-tracking branch 'php-src/master' into typed_ref_properties
  nikic
  committed
  a19b2cc
- Reduce ASSIGN_STATIC_PROP_REF specialization
  nikic
  committed
  062de9d
- Accept BP type in get_static_property
  nikic
  committed
  c91ea15
Commits on Jun 28, 2018
- Prevent type violations via array auto-promotion
  bwoebi
  committed
  50b1cf3
- Fix type check for array promotion check
  bwoebi
  committed
  4ce995d
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  dc88db9
- Restore fast-path check for uninitialized static property
  nikic
  committed
  406d594
Commits on Jun 30, 2018
- Add ReflectionProperty::isInitialized()
  bwoebi
  committed
  561f868
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  157a09d
- Minor cleanups
  nikic
  committed
  04aaea8
Commits on Jul 1, 2018
- Fix refcount on std_write_property with coercion
  bwoebi
  committed
  e8dc511
Commits on Jul 2, 2018
- Fix ReflectionProperty::isInitialized() for dynamic props
  nikic
  committed
  ef67def
- Fix ReflectionProperty::setValue() on typed static property
  nikic
  committed
  050f642
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  7d3768b
- Fix class check
  nikic
  committed
  8355232
- References are the intersection of all present property types at any time
  bwoebi
  committed
  13777bd
- Fix a last test
  bwoebi
  committed
  428a00f
Commits on Jul 3, 2018
- Remove 't' zpp type
  nikic
  committed
  e888cf1
- Drop ARRAY_ASSIGNABLE as well
  nikic
  committed
  d35b338
Commits on Jul 4, 2018
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  dee7710
- Abort early on exception in extract()
  nikic
  committed
  3bfbbf8
- Move throwing of error into verify_ref_assignable_zval()
  nikic
  committed
  acd013c
- Don't constrain type intersections
  nikic
  committed
  a10222e
Commits on Jul 11, 2018
- Merge branch 'master' of https://github.com/php/php-src into typed_ref_properties
  bwoebi
  committed
  2eadd9e
- Fix build without execute_data $register
  bwoebi
  committed
  ae8a198
Commits on Jul 13, 2018
- Move push/pop function prologue off fast path in VM
  bwoebi
  committed
  eda393b
Commits on Jul 16, 2018
- Resolve aliases during property type LSP checks
  nikic
  committed
  1f73729
- Check for conflicting property types in traits
  nikic
  committed
  7f25e95
Commits on Jul 21, 2018
- Fix write_property handlers and add zend_std_get_property_with_info
  bwoebi
  committed
  398027b
- Remove *tmp arg from zend_verify_property_type()
  bwoebi
  committed
  e7b86fb
- Remove useless separations/copies
  bwoebi
  committed
  92302a8
Commits on Jul 31, 2018
- handle by ref mysqli/PDO statement result binding
  bwoebi
  committed
  ffbf025
Commits on Aug 15, 2018
- Fix string length updates
  bwoebi
  committed
  5e2ebdc
- Merge branch 'master' into typed_ref_properties
  bwoebi
  committed
  5c94955
- Fix a last function to use zend_try_assign()
  bwoebi
  committed
  ae3e788
- Fix non-string key usage with typed properties
  bwoebi
  committed
  872084b
Commits on Sep 12, 2018
- Merge remote-tracking branch 'origin/master' into typed_ref_properties
  bwoebi
  committed
  c6310fb
Commits on Sep 13, 2018
- Merge remote-tracking branch 'origin/master' into typed_ref_properties
  bwoebi
  committed
  a7fc684
Commits on Sep 22, 2018
- Merge remote-tracking branch 'php-src/master' into typed_ref_properties
  nikic
  committed
  4f2350e
- Add test for typed properties with integer keys
  bwoebi
  committed
  0d579d0
- Remove unnecessary EXPECTFs
  nikic
  committed
  5ba37d8
- One more EXPECTF case
  nikic
  committed
  aa9a8dd
- Use seen_prop when reporting weak type error
  nikic
  committed
  8e0380b
- Add test for settype() on typed reference
  nikic
  committed
  f1a2522
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  1f235d3
Commits on Sep 23, 2018
- Minor test improvements
  nikic
  committed
  8df6714
- Drop redundant "Typed" prefix from callable/void error
  nikic
  committed
  96ea906
- Restore old zend_binary_assign_op_obj_dim code
  nikic
  committed
  494585f
- Revert some unnecessary changes
  nikic
  committed
  e8cf005
Commits on Sep 24, 2018
- Change zend_declare_typed_property to accept zend_type
  bwoebi
  committed
  c44eba9
- Fix parent private property type affecting child class
  bwoebi
  committed
  7424833
- Remove redundant ISUNDEF checks in mysqlnd
  bwoebi
  committed
  aa769fb
- Handle NULL result in assign_ref
  nikic
  committed
  eff6b11
- Fix DateInterval write_property handler
  nikic
  committed
  1147467
- Cleanup tests and improve a few error messages
  bwoebi
  committed
  236a72f
- Fix two more tests in ext/standard
  bwoebi
  committed
  f697a7b
Commits on Sep 25, 2018
Commits on Sep 27, 2018
- Remove REF flag from ASSIGN_(OBJ|STATIC_PROP)_REF
  nikic
  committed
  68abea6
- Add a missing ASSIGN_STATIC_PROP_REF case
  nikic
  committed
  e1508f2
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  64c7ca8
- Don't return pointer to stack memory
  nikic
  committed
  fe4f9f3
- Initialize return value for one exception case
  nikic
  committed
  ccf4481
Commits on Sep 28, 2018
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  7a91259
- Correctly handle resolved types in reflection
  nikic
  committed
  313590d
- Remove unused enum
  nikic
  committed
  98b8e8e
- Only lookup prop info for INDIRECT
  nikic
  committed
  6f9eac9
Commits on Sep 29, 2018
- Fix usage of self typehint in static trait properties
  bwoebi
  committed
  b8881f0
- Fix typed unint static property taken by ref being undefined
  bwoebi
  committed
  de9a77f
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  f7e6099
- Fix reflection after recent master changes
  nikic
  committed
  4ca4996
Commits on Sep 30, 2018
- Merge remote-tracking branch 'php-src/master' into typed_ref_properties
  nikic
  committed
  3e7ecb3
- Simplify code using compile_typename
  nikic
  committed
  23b1d0a
- Fix tests for master changes
  nikic
  committed
  f1e09b3
- Fix cache slot invalidation
  nikic
  committed
  02f3baa
- Prevent any incdec on integer boundaries with typed properties
  bwoebi
  committed
  c38032a
- Fix leak when modifying typed property during assignment
  bwoebi
  committed
  1d555b7
- Use zend_type_error() instead of zend_throw_exception_ex()
  bwoebi
  committed
  db13ac3
- Fix unsetting shadowed typed properties holding a reference
  bwoebi
  committed
  a119939
Commits on Oct 1, 2018
- Make all uninit access Error instead of TypeError & properly unmangle prop names
  bwoebi
  committed
  f6209ee
Commits on Oct 2, 2018
- Merge branch 'master' into typed_ref_properties
  dstogov
  committed
  5ae9a3f
- Merge branch 'master' into typed_ref_properties
  dstogov
  committed
  911e7c6
Commits on Oct 4, 2018
- Fix test
  bwoebi
  committed
  d274d58
Commits on Oct 17, 2018
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  d34cddc
Commits on Nov 22, 2018
- Merge remote-tracking branch 'php-src/master' into typed_ref_properties
  nikic
  committed
  10151f1
- Some opcache fixes
  nikic
  committed
  e231c31
Commits on Jan 2, 2019
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  18fe3b0
- Initialize unserialize_data refs
  nikic
  committed
  21e405a
Commits on Jan 3, 2019
- Check for type violations through implicit object init
  nikic
  committed
  6a27224
- Handle the reference case as well
  nikic
  committed
  25a517c
- Remove incorrect string check, add tests
  nikic
  committed
  cca6c1c
- Check for no type in "type_assignable" functions
  nikic
  committed
  373579c
- Merge branch 'master' into typed_ref_properties
  nikic
  committed
  834c8d0
- Improve auto-initialization related error messages
  nikic
  committed
  92cfec9
- Extract auto-init errors into cold helpers
  nikic
  committed
  ac1ac47
- Remove hardcoded path in test
  nikic
  committed
  0311fc5
- Handle all FETCH_OBJ flags in opcache
  nikic
  committed
  6574e7f
- Fix static prop ref sources memory leak under opcache
  nikic
  committed
  d44a513
- Fix fastcall use on Windows
  nikic
  committed
  f95ef9c
- Test tweaks
  nikic
  committed
  c0f7ab6
- Remove unnecessary flag handling in compact_literals
  nikic
  committed
  3cdaf71
- Remove unnecessary result undefing
  nikic
  committed
  eec91a2
- Add ASSIGN_STATIC_PROP to opcodes that can have unused result
  nikic
  committed
  4efefc3
- Pack obj fetch flags tighter, so it's compatible with 32 bit
  nikic
  committed
  f6257b7
- Start working on inference support for typed static props
  nikic
  committed
  f28943c
Commits on Jan 4, 2019
- Support type inference for static properties
  nikic
  committed
  4910f1d
- Don't call magic in ReflectionProperty::isInitialized()
  nikic
  committed
  78acbd7
- Remove redundant check in zend_inheritance
  nikic
  committed
  7430115
- Remove dead code
  nikic
  committed
  c5d916f
- Convert if/else to switch
  nikic
  committed
  8b71442
- Revert "Remove lchown($file, -5); test"
  nikic
  committed
  401ff4c
- Allow references to typed properties during unserialization
  nikic
  committed
  dbf7d82
- Fix type checks during unserialization
  nikic
  committed
  b1df1b7
Commits on Jan 7, 2019
- Correctly handle refs on ASSIGN_OBJ fastpath
  nikic
  committed
  bac5425
- Handle ASSIGN_STATIC_PROP compound assign in SCCP
  nikic
  committed
  882aaba
- Remove bogus check in ASSIGN_OBJ_REF
  nikic
  committed
  9788344
- Add slot to prop info mapping mechanism
  nikic
  committed
  c89b5ba
- Fix ref source removal on object destruction
  nikic
  committed
  40540b7
- Assert that all type sources have been removed when ref is dtored
  nikic
  committed
  9360955
- Use get_property_info_for slot while unsetting properties as well
  nikic
  committed
  5f7d376

Commits

Commits on May 25, 2016

Commits on May 26, 2016

Commits on May 27, 2016

Commits on May 28, 2016

Commits on Jun 7, 2016

Commits on Nov 6, 2016

Commits on Nov 13, 2016

Commits on Nov 14, 2016

Commits on Nov 18, 2016

Commits on Nov 19, 2016

Commits on Dec 5, 2016

Commits on Dec 7, 2016

Commits on Dec 9, 2016

Commits on Jan 9, 2017

Commits on Jan 10, 2017

Commits on Jan 11, 2017

Commits on Jan 13, 2017

Commits on Jan 15, 2017

Commits on Jan 16, 2017

Commits on Jun 6, 2018

Commits on Jun 7, 2018

Commits on Jun 8, 2018

Commits on Jun 9, 2018

Commits on Jun 11, 2018

Commits on Jun 12, 2018

Commits on Jun 13, 2018

Commits on Jun 14, 2018

Commits on Jun 15, 2018

Commits on Jun 16, 2018

Commits on Jun 17, 2018

Commits on Jun 18, 2018