Repository navigation
Conversation
timelib_tzinfo *tzi was being created but destroyed. Shouldn't timelib_tzinfo_dtor(tzi) be called?
Contributor
|
@jheising ping, what about the test? |
Contributor
|
I'm not sure this is right. tzi is assigned to now->tz_info, I don't think it's right to destroy it in line 1476. If fact, when I try to run it, 002.phpt fails. |
Member
|
No tests, and no further discussions. I am closing this PR for now due to open issues. Please open a new one if you update the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timelib_tzinfo *tzi was being created but destroyed. Shouldn't timelib_tzinfo_dtor(tzi) be called?