Repository navigation
Conversation
|
This does fix one issue, but introduces another. When not all results are fetched and another statement is issued on the connection, the server will return and error of "Attempt to issue another command on a connection with pending results". The existing dbcancel() should cancel the command batch, but not close the connection. It is instead closing the dbhandle for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PDO connection shouldn't end when the cursor is closed. This behavior was introduced 3 years ago when pdo_dblib was adjusted for multiple rowsets (3a069e8), only on versions 5.4+.
This prevents further queries to the same connection, transactions, the usage of variables and even getting multiple rowsets with that connection (this wasn't working on 5.4.13).
This is a bugfix for https://bugs.php.net/bug.php?id=64522. Tested and the expected results were met. Should be applied to branches PHP-5.4 and PHP-5.5.
Cheers,
Guilherme Capilé