Skip to content

Fixed memory leak of SplDoublyLinkedList::add() when set invalid index - #305

Closed
reeze wants to merge 1 commit into
php:PHP-5.5from
reeze:fix-spl-dllist
Closed

reeze wants to merge 1 commit into
php:PHP-5.5from
reeze:fix-spl-dllist

Conversation

@reeze

@reeze reeze commented Mar 20, 2013

Copy link
Copy Markdown
Contributor

When debug enabled, these tests failed:
ext/spl/tests/SplDoublyLinkedList_add_invalid_offset.phpt
ext/spl/tests/SplDoublyLinkedList_add_null_offset.phpt
ext/spl/tests/dllist_013.phpt

This affected tests:
ext/spl/tests/SplDoublyLinkedList_add_invalid_offset.phpt
ext/spl/tests/SplDoublyLinkedList_add_null_offset.phpt
ext/spl/tests/dllist_013.phpt
@php-pulls

Copy link
Copy Markdown

Comment on behalf of laruence at php.net:

thanks, but a better fix has been committed in da6916a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants