Add support for non-scalar foreach keys

[nikic]

This is just a preliminary patch for the https://wiki.php.net/rfc/foreach-non-scalar-keys RFC.

[nikic]

This patch basically changes the signature for get_current_key from

int (*get_current_key)(zend_object_iterator *iter, char **str_key, uint *str_key_len, ulong *int_key TSRMLS_DC);

to

zval *(*get_current_key)(zend_object_iterator *iter TSRMLS_DC);

and does the necessary changes in all extensions (hopefully I didn't miss any ^^).

The get_current_key handler returns a zval* with already increased refcount. The return value may be NULL if and only if an exception was thrown. (Maybe this exception should be removed too, because right now I'm not sure this case is handled properly everywhere.)

Things still to do: Figure out what to do with non-string/int keys when converting to array (iterator_to_array / CacheIterator).

[datibbaw]

Awesome work! 👍

[wpajqz]

good

发自我的小米手机

datibbaw notifications@github.com编写：

Awesome work! 👍

---

Reply to this email directly or view it on GitHub:
#278 (comment)

[weltling]

Which tests can/should I run to test the patch?

[nikic]

@weltling Zend/tests and ext/spl/tests should cover the main thing. Though this change is mostly changing the use of the API in extensions all over the place, so "all of them" might be better :)

[weltling]

@nikic Ok, thought that :) I was just wondering there are no tests for the special case mentioned in the RFC. Performed them altogether now, looks good.

[reeze]

currently, zend_hash.c didn't depend on zval struct, will it better move the function to zend_API ?

[nikic]

Merged in fcc6611.