Repository navigation
Conversation
…_override option.
Contributor
|
Not sure why it is necessary - if you want different socket path, there are socket configurations, why congifure it via "localhost override"? Even more strange would be to override localhost with remote connection having nothing to do with localhost. |
|
Comment on behalf of krakjoe at php.net: The default socket location is configurable by normal means. This is not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When localhost is encoundtered in mysqlnd, it is overriden by /tmp/mysql.sock or socket_option.
Many distributions have their own custom patches to have a correct default for their distribution. This pull request adds mysqlnd.localhost_override ini option to configure it from their configuration options.
The implementation is straightforward and it is backward compatible, if you do not set it the behaviour is as it used to be.
A side effect is that you can use remote hosts as the override (tcp://ip:port). Many applications use localhost as the default host, and it would be nice if it was easier to configure it to use alternative hosts.
Another case that would also benefit is where a host goes from having mysql on the localhost to a seperate host.