Repository navigation
Conversation
Patch for line 13. Tested from mac os, centos, redhat Added some facility and feedback
Contributor
|
Looks good. Thanks! |
Contributor
|
This patch changes non-interactive script to interactive-by-default script. Not sure it's a good idea. It may be used in some packages to do some things non-interactively, so maybe it's better to keep it non-interactive, at least by default? |
Contributor
|
@b1lb0 @smalyshev has a point. Can we keep it non-interactive per default? |
Author
|
Yes of course @smalyshev and @lstrojny, i will make another pull request with this fix |
Added check for interactive terminal. If the terminal is interactive then prompt is shown.
Contributor
|
I've committed other patch to repository days ago. If it does not work for you, please submit new pull request. Thank you. |
|
Comment on behalf of yohgaki at php.net: Other fix is committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch for line 13 "integer expression expected".
Tested in bash from mac os, centos, redhat
Added some facility and feedback