Repository navigation
Conversation
Contributor
|
After testing on windows i've made everything into a patch http://belsky.info/phpz/pulls/stas_46439.patch . Especially it regards to the PHPAPI macros usage as it evals to the __declspec(dllimport) and that's not what the code expected to do. Of course curl_CURLFile_class could be defined just locally if it wouldn't need to be exported. Tests pass though with this small tweaks. |
Contributor
Author
|
@weltling thanks, merged. |
|
Comment on behalf of stas at php.net: merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of CurlFile RFC - please see https://wiki.php.net/rfc/curl-file-upload. Can be amended following discussion on the list.