Repository navigation
JIT: Fix TLS access with SHM reattachment - #24355
Merged
Merged
Conversation
Member
Author
|
@alvin0319 could you confirm that this fixes the issue for you? |
Hi, thanks for letting me know. The PR fixed issue. I ran same tests on my side and it didn't crash, Awesome! Thanks for your quick work on this! |
arnaud-lb
added a commit
that referenced
this pull request
Oct 16, 2026
* PHP-8.6: JIT: Fix TLS access with SHM reattachment (#24355)
shivammathur
pushed a commit
to shivammathur/php-src
that referenced
this pull request
Oct 16, 2026
* PHP-8.5: JIT: Fix TLS access with SHM reattachment (php#24355)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix GH-24185.
Different processes may load modules in a different order, so TLS variables may have different offsets. This is an issue when JIT hard-codes those offsets into generated code that may be executed by other processes.
Fix by not resolving the TLS offsets when ZEND_OPCACHE_SHM_REATTACHMENT is defined, so that generated code falls back to runtime resolution.