Skip to content

Fix opcache.interned_strings_buffer being 0 in threads started later (ZTS) #24275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pavimus wants to merge 2 commits into from
Closed

Fix opcache.interned_strings_buffer being 0 in threads started later (ZTS) #24275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa7ff12
Fix opcache.interned_strings_buffer being 0 in threads started later …
pavimus Oct 9, 2026
51df7a0
Address review comment
pavimus Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ext/opcache/zend_accelerator_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,12 @@ static ZEND_INI_MH(OnUpdateMemoryConsumption)

static ZEND_INI_MH(OnUpdateInternedStringsBuffer)
{
if (accel_startup_ok) {
/* Under ZTS, every thread started later re-applies the INI entries at
* ZEND_INI_STAGE_STARTUP to fill its own globals. Accepting that is safe: the
* value comes from the global INI directives, so it is the one OPcache was
* set up with. NTS does not have this problem: STARTUP handlers run before
* accel_startup_ok is set, and accel_shutdown() clears it again. */
if (accel_startup_ok && stage != ZEND_INI_STAGE_STARTUP) {
if (strcmp(sapi_module.name, "fpm-fcgi") == 0) {
zend_accel_error(ACCEL_LOG_WARNING, "opcache.interned_strings_buffer cannot be changed when OPcache is already set up. Are you using php_admin_value[opcache.interned_strings_buffer] in an individual pool's configuration?\n");
} else {
Expand Down
Loading