Skip to content

Fix unpack() offset error naming a nonexistent parameter #24215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LamentXU123 merged 1 commit into from
Oct 9, 2026
Merged

Fix unpack() offset error naming a nonexistent parameter #24215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/standard/pack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ PHP_FUNCTION(unpack)


if (offset < 0 || offset > inputlen) {
zend_argument_value_error(3, "must be contained in argument #2 ($data)");
zend_argument_value_error(3, "must be contained in argument #2 ($string)");
RETURN_THROWS();
}

Expand Down
12 changes: 10 additions & 2 deletions ext/standard/tests/strings/unpack_offset.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,17 @@ try {
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}

/* the message names argument #2, so that name has to be the real one */
foreach ((new ReflectionFunction('unpack'))->getParameters() as $parameter) {
echo '$', $parameter->getName(), "\n";
}
?>
--EXPECT--
0x01020304 0x05060708
0x01020304 0x05060708
ValueError: unpack(): Argument #3 ($offset) must be contained in argument #2 ($data)
ValueError: unpack(): Argument #3 ($offset) must be contained in argument #2 ($data)
ValueError: unpack(): Argument #3 ($offset) must be contained in argument #2 ($string)
ValueError: unpack(): Argument #3 ($offset) must be contained in argument #2 ($string)
$format
$string
$offset
Loading