Conversation
devnexen
reviewed
Oct 5, 2026
| if (filename) { | ||
| free_filename = true; | ||
| } else { | ||
| filename = php_ini_file_name; |
Member
There was a problem hiding this comment.
What should be done instead is to reject the file so it behaves like ZTS ("disagreement" between ZTS and NTS is shown through partial CI failures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ini file passed with
-c(orPHPRC) is a relative path, it can be opened fine whileexpand_filepath()still returns NULL, because the cwd plus the relative path goes over MAXPATHLEN.filenamethen ends up NULL and thestrlen(filename)forcfg_file_pathsegfaults. Falling back to the path as given avoids the crash. The test reproduces it with a long run of./in front of the ini name.Fixes #24139