Skip to content

ext/intl: Fix overlapping grapheme matches with negative search offsets - #24028

Merged
LamentXU123 merged 2 commits into
php:PHP-8.4from
LamentXU123:grapheme_fix_1
Oct 2, 2026
Merged

ext/intl: Fix overlapping grapheme matches with negative search offsets#24028
LamentXU123 merged 2 commits into
php:PHP-8.4from
LamentXU123:grapheme_fix_1

Conversation

@LamentXU123

@LamentXU123 LamentXU123 commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member 
<?php
var_dump(grapheme_strrpos("ééé", "éé", -1));
var_dump(grapheme_strripos("ééé", "ÉÉ", -1));
// current: int(0)、int(0)
// expected: int(1)、int(1)

How is this function even make sense for so many years?!

@LamentXU123 LamentXU123 mentioned this pull request Sep 30, 2026
Merged
@LamentXU123
LamentXU123 merged commit be5442d into php:PHP-8.4 Oct 2, 2026
1 of 2 checks passed
LamentXU123 added a commit that referenced this pull request Oct 2, 2026
@LamentXU123
Merge branch 'PHP-8.6'
82b8dce 
* PHP-8.6:
  ext/intl: Fix overlapping grapheme matches with negative search offsets (#24028)
devnexen pushed a commit to devnexen/php-src that referenced this pull request Oct 2, 2026
@LamentXU123
Merge branch 'PHP-8.4' into PHP-8.5
e8dfd8e 
* PHP-8.4:
  ext/intl: Fix overlapping grapheme matches with negative search offsets (php#24028)
devnexen pushed a commit to devnexen/php-src that referenced this pull request Oct 2, 2026
@LamentXU123
Merge branch 'PHP-8.5' into PHP-8.6
61299e0 
* PHP-8.5:
  ext/intl: Fix overlapping grapheme matches with negative search offsets (php#24028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexen devnexen devnexen approved these changes

Assignees

No one assigned

Labels

Extension: intl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LamentXU123 @devnexen