Repository navigation
ext/uri: Fixes url delimiters - #23815
Conversation
|
Compiled a matrix of the query/fragment behaviours. Leaving it here in case it's helpful for your policy discussion above. Fragment MatrixQuery Matrix |
kocsismate
left a comment
There was a problem hiding this comment.
a few remarks, but thank you very much for the fixes! I'm going to change the target to PHP-8.6
|
Can you please resolve the conflicts + resolve my previous comments? |
120ff96 to
60911e5
Compare
|
Did anyone find time to look at the Fragment Matrix I posted above? Does that all look right? Will address the review comments when it is clear that everything is indeed intended behaviour (including the gotchas I am trying to point out). |
I briefly did, and they were in line with the expectations. Since we agreed on going with the setters' behavior, this PR should address my review comments to satisfy the newly set requirements. In my opinion, it will be immediately possible to merge the PR afterwards :) |
60911e5 to
dfa46bb
Compare
* PHP-8.6: ext/uri: Fixes url delimiters (#23815)
|
thank you for the help! I needed to go ahead with the merge so that the changes are merged well before the final 8.6 release. |
No description provided.