Fix DateTime, when use it with D/l in format and textual day have dot at...

[gron1987]

Fix DateTime, when use it with D/l in format and textual day have dot at the end

For example :

$string = "Sun., Nov. 29, 2012 5:00PM";

$data = DateTime::createFromFormat( "D., M# j, Y g:iA", $string );

var_dump( $data );
var_dump( DateTime::getLastErrors() );

return

bool(false)
array(4) {
  'warning_count' =>
  int(0)
  'warnings' =>
  array(0) {
  }
  'error_count' =>
  int(2)
  'errors' =>
  array(2) {
    [0] =>
    string(32) "A textual day could not be found"
    [4] =>
    string(40) "The separation symbol could not be found"
  }
}

This fix add more stop characters ( from # )

[lstrojny]

Could you please add a test for it?

[lstrojny]

ping @gron1987

[gron1987]

@lstrojny Sorry, crazy month. Will update tomorrow

[lstrojny]

@gron1987 which "tomorrow" exactly? ;-)

[gron1987]

@lstrojny Creating it now ) Just try to understand how it works :)

[gron1987]

@lstrojny
Added yesterday

[lstrojny]

@derick could you review?

[gron1987]

ping @lstrojny @derick

[lstrojny]

Sorry @gron1987, @derick ping again

[lstrojny]

@derick ping again

[gron1987]

@lstrojny @derickr ping ? :)

[derickr]

I'm on holiday. If you could mail me a list of the issues in datetime then I'll look at asap

http://derickrethans.nl - http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug

[smalyshev]

This patch doesn't see to be correct. First, the file that needs to be patched is parse_date.re since parse_date.c is generated from it. Second, the test still fails for me.

[php-pulls]

Comment on behalf of stas at php.net:

I've fixed the patch and merged it