Repository navigation
Conversation
TEST after change ===================================================================== PHP : /home/vagrant/php-src/sapi/cli/php PHP_SAPI : cli PHP_VERSION : 7.2.0-dev ZEND_VERSION: 3.2.0-dev PHP_OS : Linux - Linux lubunut32 3.13.0-36-generic #63-Ubuntu SMP Wed Sep 3 21:30:45 UTC 2014 i686 INI actual : /home/vagrant/php-src/tmp-php.ini More .INIs : --------------------------------------------------------------------- PHP : /home/vagrant/php-src/sapi/phpdbg/phpdbg PHP_SAPI : phpdbg PHP_VERSION : 7.2.0-dev ZEND_VERSION: 3.2.0-dev PHP_OS : Linux - Linux lubunut32 3.13.0-36-generic #63-Ubuntu SMP Wed Sep 3 21:30:45 UTC 2014 i686 INI actual : /home/vagrant/php-src/tmp-php.ini More .INIs : --------------------------------------------------------------------- CWD : /home/vagrant/php-src Extra dirs : VALGRIND : Not used ===================================================================== Running selected tests. TEST 1/1 [tests/basic/timeout_variation_9.phpt] FAIL Timeout within shutdown function [tests/basic/timeout_variation_9.phpt] ===================================================================== Number of tests : 1 1 Tests skipped : 0 ( 0.0%) -------- Tests warned : 0 ( 0.0%) ( 0.0%) Tests failed : 1 (100.0%) (100.0%) Expected fail : 0 ( 0.0%) ( 0.0%) Tests passed : 0 ( 0.0%) ( 0.0%) --------------------------------------------------------------------- Time taken : 4 seconds ===================================================================== ===================================================================== FAILED TEST SUMMARY --------------------------------------------------------------------- Timeout within shutdown function [tests/basic/timeout_variation_9.phpt] ===================================================================== TEST BEFORE change ===================================================================== PHP : /home/vagrant/php-src/sapi/cli/php PHP_SAPI : cli PHP_VERSION : 7.2.0-dev ZEND_VERSION: 3.2.0-dev PHP_OS : Linux - Linux lubunut32 3.13.0-36-generic #63-Ubuntu SMP Wed Sep 3 21:30:45 UTC 2014 i686 INI actual : /home/vagrant/php-src/tmp-php.ini More .INIs : --------------------------------------------------------------------- PHP : /home/vagrant/php-src/sapi/phpdbg/phpdbg PHP_SAPI : phpdbg PHP_VERSION : 7.2.0-dev ZEND_VERSION: 3.2.0-dev PHP_OS : Linux - Linux lubunut32 3.13.0-36-generic #63-Ubuntu SMP Wed Sep 3 21:30:45 UTC 2014 i686 INI actual : /home/vagrant/php-src/tmp-php.ini More .INIs : --------------------------------------------------------------------- CWD : /home/vagrant/php-src Extra dirs : VALGRIND : Not used ===================================================================== Running selected tests. TEST 1/1 [tests/basic/timeout_variation_9.phpt] PASS Timeout within shutdown function [tests/basic/timeout_variation_9.phpt] ===================================================================== Number of tests : 1 1 Tests skipped : 0 ( 0.0%) -------- Tests warned : 0 ( 0.0%) ( 0.0%) Tests failed : 0 ( 0.0%) ( 0.0%) Expected fail : 0 ( 0.0%) ( 0.0%) Tests passed : 1 (100.0%) (100.0%) --------------------------------------------------------------------- Time taken : 5 seconds =====================================================================
krakjoe
changed the title
krakjoe
reviewed
Feb 2, 2017
| @@ -1,5 +1,7 @@ | |||
| --TEST-- | |||
| Timeout within shutdown function | |||
| --CREDITS-- | |||
Member
There was a problem hiding this comment.
You didn't write this test: If every tiny change of a test lead to someone entering their names in credits section, all tests would soon become unmanageable.
Contributor
Author
|
Ok, I will remove credits tag in PR.
Thanks
…On Feb 2, 2017 14:24, "Joe Watkins" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/basic/timeout_variation_9.phpt
<#2359 (review)>:
> @@ -1,5 +1,7 @@
--TEST--
Timeout within shutdown function
+--CREDITS--
You didn't write this test: If every tiny change of a test lead to someone
entering their names in credits section, all tests would soon become
unmanageable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2359 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAbCb4pqJwPE1EnxB_4057rLO4Jd0uL-ks5rYgMggaJpZM4L0g3d>
.
|
Removed CREDITS tag, because I did not write this test, I only made a small adjust.
Contributor
Author
|
@krakjoe Done! Thanks for feedback. |
Member
|
Merged 0b56ba5 Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST before change
TEST AFTER change