Skip to content

Fixed bug #60285 (setting REPORT_EXIT_STATUS for make test won't work) - #235

Closed
reeze wants to merge 1 commit into
php:masterfrom
reeze:bug60285
Closed

reeze wants to merge 1 commit into
php:masterfrom
reeze:bug60285

Conversation

@reeze

@reeze reeze commented Nov 24, 2012

Copy link
Copy Markdown
Contributor

See https://bugs.php.net/bug.php?id=60285

This is related to PR #232

after the patch:
REPORT_EXIT_STATUS=1 make test will works as expected`

this makes ci like travis easier

BTW @lstrojny #232 was merged to master only, I thought both #232 and this PR could apply
to all branches, or at least 5.5, what do you think?

@php-pulls

Copy link
Copy Markdown

Comment on behalf of laruence at php.net:

this fix changed the behavior, that is the tmp-php.ini will not be clean if the test make failed, so I prefer the patch attached at the bug entry.

thanks

@php-pulls php-pulls closed this Nov 25, 2012
@reeze

reeze commented Nov 25, 2012

Copy link
Copy Markdown
Contributor Author

There is a reason: when tests failed, run-test.php will save test script like: Zend/tests/bug1234.sh we could use the sh files to re-run tests,
it use the tmp-php.ini as configure file, but if the tmp-php.ini was deleted re-run it will not be exactly the same
as it was run with make test and if it was not deleted, it will be easier to debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants