Repository navigation
Fix GH-11310: __debugInfo does nothing on userland classes extending Date classes - #22655
Merged
Merged
Conversation
…ng Date classes
| Bug GH-11310: __debugInfo does nothing on userland classes extending Date classes | ||
| --FILE-- | ||
| <?php | ||
| class UDateTime extends DateTime { public function __debugInfo(): array { return ['value' => 'zzz']; } } |
Member
There was a problem hiding this comment.
can you also add cases where the parent constructor is not called, to ensure that the parent constructor isn't doing any initialization that is required for the overrides to work?
and at least one case of calling parent::__debugInfo() and confirming that the parent info still shows up
Member
Author
There was a problem hiding this comment.
I tried adding a test with calling parent::_debugInfo(), but none of the classes have a __debugInfo() method, so that would just be testing calling an undefined method.
I've added tests for when the ctor of the original classes isn't called.
pull Bot
pushed a commit
to ppker/php-src
that referenced
this pull request
Jul 10, 2026
* PHP-8.4: Fix phpGH-11310: __debugInfo does nothing on userland classes extending Date classes (php#22655)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for
DateTimealso works forDateTimeImmutable, butDateTimeZoneneeded a separate fix.I have also ran tests with valgrind locally, to make sure there are no memory issues.
Related to: #16317