Skip to content

Support building using the native client toolchain. - #205

Closed
sjlangley wants to merge 8 commits into
php:masterfrom
sjlangley:master
Closed

sjlangley wants to merge 8 commits into
php:masterfrom
sjlangley:master

Conversation

@sjlangley

Copy link
Copy Markdown

Add build rules for cross compiling using a native client compiler.

Add correct defines around inline asm so that the correct code is built for native client.

Stuart Langley added 7 commits September 13, 2012 17:37
The native client compiler defines the C macro __x86_64__, but the size
of an unsigned int is only 4 bytes. This causes the compile to fail
because the inline asm code compiled is for an 8 byte unsigned int. Add
the correct defines to fix this.

As detailed in:
http://code.google.com/p/nativeclient/issues/detail?id=2255
* PHP-5.4:
  Support building PHP with the native client toolchain.
* 5.4-nacl:
  Support building PHP with the NaCl toolchain.
Use the correct basic_machine for nacl.
More wrapping of inline __asm__ with defined(__native_client__)
These inline asm statements are incompatible with native client, and give errors when running ncval, which cause the binary to fail loading.
@lstrojny

lstrojny commented Jan 6, 2013

Copy link
Copy Markdown
Contributor

@sjlangley I feel incompetent to do anything useful with this PR (and btw sorry for the long time without any response). I guess the best way forward would be, if you write a mail to internals explaining what your plans are with NaCl and ask for karma to maintain NaCl support.

@sjlangley

Copy link
Copy Markdown
Author

Thanks - will look into it.

On Sun, Jan 6, 2013 at 12:38 PM, Lars Strojny notifications@github.comwrote:

@sjlangley https://github.com/sjlangley I feel incompetent to do
anything useful with this PR (and btw sorry for the long time without any
response). I guess the best way forward would be, if you write a mail to
internals explaining what your plans are with NaCl and ask for karma to
maintain NaCl support.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/205#issuecomment-11922909.

@lstrojny

Copy link
Copy Markdown
Contributor

Really, please do. I would love to see NaCl support in PHP.

Conflicts:
	Zend/zend_operators.h
	config.sub
@smalyshev

Copy link
Copy Markdown
Contributor

This patch deletes Zend/zend_operators.h. Not something that should be done. Please squash and re-do it correctly.

@php-pulls

Copy link
Copy Markdown

Comment on behalf of krakjoe at php.net:

This PR is in very poor condition.

If this is still a problem that needs solving, anyone watching is free to open a clean PR.

Closing ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants