Repository navigation
Revert deprecation of __sleep and __wakeup - #19966
Merged
Merged
Conversation
nicolas-grekas
requested review from
Girgias,
SakiTakamachi,
bukka,
derickr,
kamil-tekiela and
ndossche
as code owners
September 25, 2025 18:22
nicolas-grekas
force-pushed
the
revert-sleep-wakeup-deprec
branch
2 times, most recently
from
September 25, 2025 18:27
30913e3 to
6f3c8f2
Compare
Contributor
Author
|
I'm wondering if it's worth reverting #19827 given that the affected classes already have |
TimWolla
reviewed
Sep 25, 2025
TimWolla
reviewed
Sep 25, 2025
nicolas-grekas
force-pushed
the
revert-sleep-wakeup-deprec
branch
from
September 26, 2025 07:23
a7d54d1 to
0375921
Compare
Contributor
Author
|
Thanks for the review, I removed the commits that reverted NEWS updates and also removed the revert of #19827, which can and should be kept to me. |
nicolas-grekas
force-pushed
the
revert-sleep-wakeup-deprec
branch
from
September 26, 2025 07:26
0375921 to
ea69ff6
Compare
TimWolla
reviewed
Sep 26, 2025
nicolas-grekas
force-pushed
the
revert-sleep-wakeup-deprec
branch
from
September 26, 2025 07:50
ea69ff6 to
32ffdd0
Compare
Girgias
reviewed
Sep 30, 2025
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Minor comments, but LGTM otherwise.
nicolas-grekas
force-pushed
the
revert-sleep-wakeup-deprec
branch
from
September 30, 2025 13:56
32ffdd0 to
0b844d4
Compare
ndossche
approved these changes
Sep 30, 2025
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Looks fine from a technical PoV
theodorejb
reviewed
Oct 1, 2025
edorian
approved these changes
Oct 2, 2025
edorian
left a comment
edorian
left a comment
Member
There was a problem hiding this comment.
On the, likely, condition that the RFC passes: 👍 RM wise.
Thank you for getting everything ready, making it easy to stay within the plan made to get this sorted cleanly. Much appreciated.
nicolas-grekas
force-pushed
the
revert-sleep-wakeup-deprec
branch
from
October 2, 2025 11:09
0b844d4 to
e5ae1d8
Compare
nicolas-grekas
force-pushed
the
revert-sleep-wakeup-deprec
branch
from
October 6, 2025 06:47
e5ae1d8 to
f58da91
Compare
Member
|
I was planning to review this today and then merge it, sorry for the delay - looks good to me and I guess has already been merged |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Sep 30, 2026
…recations (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [PhpUnitBridge] Remove silencing of __sleep/wakeup() deprecations | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Reverts #61729: the deprecation of `__sleep()`/`__wakeup()` was reverted in php-src before 8.5.0 (php/php-src#19966), so these messages are never triggered anymore. Commits ------- ef80b0a [PhpUnitBridge] Remove silencing of __sleep/wakeup() deprecations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without precluding the result of the vote at https://wiki.php.net/rfc/soft-deprecate-sleep-wakeup
I'm trying to help PHP 8.5 RMs get ready for RC2, as advised in this message:
https://externals.io/message/128643#128659
This PR reverts the commits on the topic, related to PRs #19682 and #19435
It also reverts #19827Reviews welcome to ensure this can be merged on Oct. 4th if the vote passes.
/cc @DanielEScherzer @edorian