Skip to content

Bug #62479 Fix bug where spaces in passwords would fail - #199

Closed
willfitch wants to merge 3 commits into
php:masterfrom
willfitch:bug-62479
Closed

willfitch wants to merge 3 commits into
php:masterfrom
willfitch:bug-62479

Conversation

@willfitch

Copy link
Copy Markdown
Contributor

Change-Id: I53679937d69b0a8897961900ebf33d197b8ce018

Change-Id: I53679937d69b0a8897961900ebf33d197b8ce018
@lstrojny

Copy link
Copy Markdown
Contributor

Thanks! We need a test for that.

@willfitch

Copy link
Copy Markdown
Contributor Author

Test added @lstrojny

@dsp

dsp commented Oct 30, 2012

Copy link
Copy Markdown
Member

Maybe @iliaal want to have a look,he is the official maintainer.

@iliaal

iliaal commented Oct 31, 2012

Copy link
Copy Markdown
Member

I think the patch inside http://ilia.ws/patch/pdo.txt maybe better, as it also accounts for the possibility of the password containing \ character.

@lstrojny

lstrojny commented Jan 6, 2013

Copy link
Copy Markdown
Contributor

@iliaal will you merge your patch and close this PR?

@lstrojny

Copy link
Copy Markdown
Contributor

@iliaal ping

@smalyshev

Copy link
Copy Markdown
Contributor

@willfitch any news?

@php-pulls

Copy link
Copy Markdown

Comment on behalf of stas at php.net:

Looks like this one is abandoned. Since Ilia thinks different patch is better, closing this one.

@php-pulls php-pulls closed this Aug 5, 2013
@willfitch

Copy link
Copy Markdown
Contributor Author

Where did this go? Just trying to see if @iliaal's patch made it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants