Repository navigation
Conversation
There was a problem hiding this comment.
The whitespace change highlighted the typo here. "temporarily unavailable" would be correct. Do you mind changing it?
|
The patch looks good to me. With the one exception of the spelling error (which is outside of the scope of the PR anyway, but could be fixed)... |
|
@lstrojny, @ircmaxell The typo has been fixed. |
|
just one thing, I think the error response should before the dispatch... maybe in the read_request phase. |
|
@laruence I moved the response into |
|
Thanks, good to me now |
|
Alright, will take of it this weekend. Checked with stas, we also merge into 5.4 |
|
@nikcorg could you rebase and squash your commits? |
|
@lstrojny I think I just did that. |
Fixed typo Moved 501 response from dispatch to event_read_request Return return value of send_error_page
|
Comment on behalf of stas at php.net: merged |
5 participants
This patch adresses the issue mentioned in Bug #61679, but with the difference of responding with
501 Not Implemented(instead of405 Method Not Allowed) as per RFC2616 Section 5.1.1.(Sorry about the whitespace changes, I always [automatically] trim trailing whitespace and didn't see this happening before it was too late.)