Skip to content

Fix memory leaks in array_any() / array_all() - #17977

Closed
ndossche wants to merge 1 commit into
php:PHP-8.4from
ndossche:fix-array-leaks
Closed

ndossche wants to merge 1 commit into
php:PHP-8.4from
ndossche:fix-array-leaks

Conversation

@ndossche

@ndossche ndossche commented Mar 5, 2025

Copy link
Copy Markdown
Member

The return value is overwritten, but if the key was not an interned string we should destroy it.

The return value is overwritten, but if the key was not an interned
string we should destroy it.

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ndossche added a commit that referenced this pull request Mar 5, 2025
The return value is overwritten, but if the key was not an interned
string we should destroy it.

Closes GH-17977.
@ndossche ndossche closed this in 83722a5 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants