Skip to content

Test Firebird in 32-bit Linux CI - #17045

Merged
ndossche merged 2 commits into
php:masterfrom
ndossche:firebird-32bit-take-2
Dec 6, 2024
Merged

ndossche merged 2 commits into
php:masterfrom
ndossche:firebird-32bit-take-2

Conversation

@ndossche

@ndossche ndossche commented Dec 4, 2024

Copy link
Copy Markdown
Member

No description provided.

Co-authored-by: =?UTF-8?q?=E6=AD=A6=E7=94=B0=20=E6=86=B2=E5=A4=AA=E9=83=8E?= <takeda@youmind.jp>
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>

@SakiTakamachi SakiTakamachi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SakiTakamachi SakiTakamachi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SakiTakamachi

Copy link
Copy Markdown
Member

Duplicate post? Please ignore...

Comment thread ext/pdo_firebird/tests/bug_76448.phpt Outdated
A bug in firebird causes a memory leak when calling `isc_attach_database()`.
See https://github.com/FirebirdSQL/firebird/issues/7849
--SKIPIF--
<?php if (PHP_INT_SIZE != 8) die("skip: 64-bit only"); ?>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
<?php if (PHP_INT_SIZE != 8) die("skip: 64-bit only"); ?>
<?php if (PHP_INT_SIZE != 8) die("skip 64-bit only"); ?>

Otherwise run-tests.php will report reason: : 64-bit only.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@ndossche
ndossche merged commit 912b13a into php:master Dec 6, 2024
@iluuu1994

iluuu1994 commented Dec 7, 2024 •

Copy link
Copy Markdown
Member

This does not work in nightly, apparently. https://github.com/php/php-src/actions/runs/12208755353/job/34062517782 The changes from .github/workflows/push.yml should be ported to nightly.yml.

@ndossche

ndossche commented Dec 7, 2024

Copy link
Copy Markdown
Member Author

See #17080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants