Repository navigation
Fixed bug #62852 (Unserialize invalid DateTime causes crash) - #168
Merged
Merged
Conversation
Contributor
Author
|
updated, thanks, |
Member
|
please do not do force-update... -_# all the conversation are valuable... it reflects how your fix become a proper one... |
Contributor
Author
|
hm…. that seems a bad style… I was intend to make the commit clean, reeze | http://reeze.cn 在 2012年8月19日星期日，下午5:57，Xinchen Hui 写道：
|
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 13, 2026
fix: an edit to a PHP# class, interface or enum header re-checks every file that reads it
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 13, 2026
Problem: master moved 10 commits past f14c7b6, the last master this branch merged: php#167 installs Lean on first use, and php#168 re-checks every file that reads a class, interface or enum header after an edit to it. Solution: merge d3adf51 with no rebase. Git merged every file on its own, and no file both sides changed needed a hand resolution. One composition was checked by reading: php#168 hashes each `Inheritance` entry as a `Hint`, and on this branch a header entry with type arguments is a `Hint::Generic`, whose fingerprint already hashes its type arguments. So an edit to `Orders : Source<Order>` re-checks the files that read `Orders`. Cargo.toml, Cargo.lock php#167's dependencies crates/ ├── fingerprint/src/class_like/mod.rs php#168's header hash ├── orchestrator/src/service/incremental_analysis/ php#168's header edit test └── sharp-lean/src/ php#167's Lean install tests/compile.rs php#167's missing-lean rows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bug #62852 https://bugs.php.net/bug.php?id=62852
When wakeup from an invalid datetime it didn't complain but in inconsistant status.
This causes crash when access.
Thanks